Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort support #185

Closed
jack-sf opened this issue Jun 11, 2019 · 1 comment
Closed

Abort support #185

jack-sf opened this issue Jun 11, 2019 · 1 comment

Comments

@jack-sf
Copy link

jack-sf commented Jun 11, 2019

Have you thought about adding support also for aborting the reqeusts? ( https://developer.mozilla.org/en-US/docs/Web/API/AbortController/abort )

On browser environment, we could use have a ponyfill similar to this polyfill: https://github.com/mo/abortcontroller-polyfill .

On node environment, node-fetch seems to already support AbortController: node-fetch/node-fetch#95 .

So this fetch-ponyfill could also ponyfill the abortcontroller, and export AbortController and AbortSignal. WDYT?

@qubyte
Copy link
Owner

qubyte commented Jun 11, 2019

I see no need. It looks like abortcontroller-polyfill is already usable as a ponyfill already, and when node-fetch supports abort, it'll get into this library naturally as dependencies are updated.

@qubyte qubyte closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants