nrepl-eval-sexp-fu fails to install

[steckerhalter]

recipe:

(quelpa '(nrepl-eval-sexp-fu :fetcher github :repo samaaron/nrepl-eval-sexp-fu))

it fails at this function:

(defun quelpa-get-package-desc (file)
  "Extract and return the PACKAGE-DESC struct from FILE.
On error return nil."
  (with-demoted-errors "Error getting PACKAGE-DESC: %s"
    (with-temp-buffer
      (insert-file-contents-literally file)
      (pcase (quelpa-package-type file)
        (`single (package-buffer-info)) ; <--------------- fails here, returns nil
        (`tar (tar-mode)
              (with-no-warnings (package-tar-file-info)))))))

I checked and the buffer is inserted correctly. Seems like an issue with package-buffer-info

[wasamasa]

See this comment. Let's hope that missing closing paren is the entire reason, although I still have no idea how MELPA works with it then.

[krisajenkins]

Doh! Fixed (and double-checked) here: samaaron/nrepl-eval-sexp-fu#9

[wasamasa]

Did a quick test and it works now. Thanks.

[steckerhalter]

Debugger entered--Lisp error: (error "Package `thingatpt-0.0.0' is unavailable")
  signal(error ("Package `thingatpt-0.0.0' is unavailable"))
  error("Package `%s-%s' is unavailable" thingatpt "0.0.0")
  package-compute-transaction(nil ((highlight (0 0 0)) (smartparens (0 0 0)) (thingatpt (0 0 0))))
  package-install-from-buffer()
  package-install-file("/home/stk/.emacs.d/quelpa/packages/nrepl-eval-sexp-fu-20140311.1141.el")
  quelpa-package-install((nrepl-eval-sexp-fu :fetcher github :repo "samaaron/nrepl-eval-sexp-fu"))
  quelpa((nrepl-eval-sexp-fu :fetcher github :repo "samaaron/nrepl-eval-sexp-fu"))

still doesn't work for me...

;; Package-Requires: ((highlight "0.0.0") (smartparens "0.0.0") (thingatpt "0.0.0"))

thingatpt is an internal lib and package.el cannot figure that out. maybe that's a problem in Emacs trunk only?

[wasamasa]

Seems to be the case as installing with a clean 24.3 works.

[wasamasa]

OK, so apparently once MELPA switches over to 24.4 for building packages, they will encounter the same issue with packages that have internal libraries as dependencies. That's because `package-compute-transaction' checks installed packages first, then available packages, then errors out if the requested dependency isn't available.

So, we can either fix/report all packages with this error or ask upstream to silently ignore those. I'm afraid it will be the former. Please cross-check whether that's the case, then I'll hand in another bug report for the package in question.

[steckerhalter]

That's because `package-compute-transaction' checks installed packages first, then available packages, then errors out if the requested dependency isn't available.

so you mean that it doesn't check for internal libs?

what's the difference to 24.3?

[wasamasa]

So, in both package-compute-transactionuses package-built-in-p. The difference is that under 24.3 (package-built-in-p 'thingatpt) returns t, in 24.4 it returns nil. This might be a bug worth mentioning on the emacs-devel mailing list.

[steckerhalter]

the problem is the version:

(package-built-in-p 'thingatpt '(0 0 0)) ; emacs 24.4
nil
(package-built-in-p 'thingatpt '(0 0 0)) ; emacs 24.3
t

[steckerhalter]

so Stefan restored the old behavior of the function in the Emacs-24 branch:

http://lists.gnu.org/archive/html/emacs-devel/2014-03/msg01141.html

http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-24&id=ee6c02bb2873f4d9ae9671a87dbf731650726b37

[wasamasa]

Good, we'll wait then until it's added to trunk, maybe even confirmed to stay that way.