New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including Oculus Browser #359
Comments
Hi, you can already access its value directly through the parsing library using the <UserAgent returnFullParser>
{parser => (
{parser.getBrowser().name == "Oculus Browser" &&
<p>Oculus specific content</p>
}
)}
</UserAgent> Or were you thinking about adding a prop like |
Yea I was referring to adding a prop potentially |
I think there are a lot of commonly used browsers which don't have a pre-computed prop for, like Vivaldi, Mobile Safari or Brave for example. I'm not sure about adding one because it feels arbitrary. import React, {useContext} from 'react'
import {UAContext} from '../src'
const UsingContextHook = () => {
const {uaResults, parser} = useContext(UAContext)
return {
parser,
uaResults: {
...uaResults,
oculus: parser.getBrowser().name === "Oculus Browser"
}
}
}
export default UsingContextHook |
Alright thank you! :) |
With more increase of VR headset sales, it would be nice to include Oculus Browser. Is there any chance someone like me can assist through a PR to include the Oculus Browser in this library?
The text was updated successfully, but these errors were encountered: