Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat bounds in General do not include XLSX v0.8 #54

Open
angusmoore opened this issue Aug 28, 2022 · 1 comment
Open

Compat bounds in General do not include XLSX v0.8 #54

angusmoore opened this issue Aug 28, 2022 · 1 comment

Comments

@angusmoore
Copy link

Compat in Project.toml is:

XLSX = "≥ 0.4.1"

But in General, Compat.toml has XLSX = "0.4.1-0.7" (presumably because when v1 was registered XLSX 0.7 was the latest version?).

I think either Project.toml should be updated to reflect what is in General, or vice versa. I've only quickly looked, but seems to wokr fine with XLSX 0.8, although tests are failing for me regardless of XLSX version (failures seem unrelated - appear to be eg #51, #53). I think the latter option (tagging a new version and updating compat bounds in General to include XLSX 0.8) would be preferable, but I haven't thoroughly tested.

@MorsePotential
Copy link

is there any progress on this? Definitely caused issues further down the line felipenoris/XLSX.jl#236 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants