Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

busy-looping in OpenStreamSync #2824

Closed
marten-seemann opened this issue Oct 15, 2020 · 0 comments · Fixed by #2827
Closed

busy-looping in OpenStreamSync #2824

marten-seemann opened this issue Oct 15, 2020 · 0 comments · Fixed by #2827
Labels

Comments

@marten-seemann
Copy link
Member

marten-seemann commented Oct 15, 2020

When a MAX_STREAMS frame is received while there are calls to OpenStreamSync, the for loop might busy-loop:
https://github.com/lucas-clemente/quic-go/blob/51fd3c33b2c0ac9bc330de04a79229c06c97d3c6/streams_map_outgoing_generic.go#L87-L96

This occurs because unblockOpenSync closes the waitChan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant