Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: send version negotiation and invalid token packets from a single Go routine #3854

Merged
merged 2 commits into from
May 28, 2023

Conversation

sukunrt
Copy link
Collaborator

@sukunrt sukunrt commented May 23, 2023

closes: #3765

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #3854 (9cb3d20) into master (f401a73) will decrease coverage by 0.06%.
The diff coverage is 61.90%.

@@            Coverage Diff             @@
##           master    #3854      +/-   ##
==========================================
- Coverage   83.92%   83.86%   -0.06%     
==========================================
  Files         146      146              
  Lines       14307    14349      +42     
==========================================
+ Hits        12006    12033      +27     
- Misses       1860     1874      +14     
- Partials      441      442       +1     
Impacted Files Coverage Δ
server.go 75.80% <61.90%> (-2.08%) ⬇️

... and 3 files with indirect coverage changes

@sukunrt sukunrt marked this pull request as draft May 23, 2023 11:51
@sukunrt sukunrt marked this pull request as ready for review May 23, 2023 18:39
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work! Thank you!

@marten-seemann marten-seemann changed the title server: send version negotiation and invalid token packets from a single go routine server: send version negotiation and invalid token packets from a single Go routine May 28, 2023
@marten-seemann marten-seemann merged commit 1951878 into quic-go:master May 28, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit number of Go routines spawned when receiving unexpected packets
2 participants