Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in v0.37.0: ClientHelloInfo.Conn is nil #4000

Closed
marten-seemann opened this issue Jul 28, 2023 · 1 comment · Fixed by #4001
Closed

regression in v0.37.0: ClientHelloInfo.Conn is nil #4000

marten-seemann opened this issue Jul 28, 2023 · 1 comment · Fixed by #4001
Labels
bug
Milestone
v0.37.1

Comments

@marten-seemann
Copy link
Member

See golang/go#61639 for details. Either Go resolves it (and we have to backport it to qtls for Go 1.20), or we'll have to wrap GetClientHelloInfo.
@marten-seemann marten-seemann pinned this issue Jul 28, 2023
@marten-seemann marten-seemann added this to the v0.37.1 milestone Jul 28, 2023
@mholt
Copy link
Contributor

mholt commented Jul 28, 2023

Thanks for being so proactive with this project, Marten 💯

@marten-seemann marten-seemann mentioned this issue Jul 29, 2023
Merged
@marten-seemann marten-seemann unpinned this issue Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.37.1
Development

Successfully merging a pull request may close this issue.

set a net.Conn with the correct addresses on the tls.ClientHelloInfo quic-go/quic-go
2 participants
@mholt @marten-seemann