set the handshake timeout to twice the handshake idle timeout #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
less-magical-connection-timeout
branch
from
909a78a
to
49b51dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #4063 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 147 147
Lines 14906 14906
=======================================
Hits 12443 12443
Misses 1967 1967
Partials 496 496
|
marten-seemann
force-pushed
the
less-magical-connection-timeout
branch
from
49b51dc
to
9d754f8
Compare
sukunrt
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't remember why we introduced a fixed 10s minimum value for the handshake timeout. It seems more consistent to make this configurable all the way through.