remove Config.MaxRetryTokenAge, set it to the handshake timeout #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4064 +/- ##
==========================================
- Coverage 83.46% 83.44% -0.02%
==========================================
Files 147 147
Lines 14890 14888 -2
==========================================
- Hits 12427 12422 -5
- Misses 1967 1970 +3
Partials 496 496
|
marten-seemann
force-pushed
the
remove-config-maxretrytokenage
branch
from
466fa4e
to
95c185b
Compare
marten-seemann
changed the base branch from
less-magical-connection-timeout
to
master
sukunrt
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
can remove this too, I think. https://github.com/quic-go/quic-go/blob/master/config_test.go#L83
There is no good reason to manually set the validity period for Retry tokens. Retry tokens are only valid on a single connection during the handshake, so it makes sense to limit their validity to the configured handshake timeout.
marten-seemann
force-pushed
the
remove-config-maxretrytokenage
branch
from
95c185b
to
c136f66
Compare
Done! Thanks for catching this! |
sukunrt
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4063. For #3549.
There is no good reason to manually set the validity period for Retry tokens. Retry tokens are only valid on a single connection during the handshake, so it makes sense to limit their validity to the configured handshake timeout.