move MaxTokenAge configuration option to the Transport #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4084 +/- ##
==========================================
- Coverage 83.59% 83.57% -0.02%
==========================================
Files 148 148
Lines 15227 15225 -2
==========================================
- Hits 12728 12723 -5
- Misses 1999 2001 +2
- Partials 500 501 +1
|
marten-seemann
force-pushed
the
configure-max-token-age
branch
from
f6a11be
to
cafbe32
Compare
sukunrt
approved these changes
Sep 16, 2023
| @@ -68,7 +61,7 @@ func (s *tokenProtectorImpl) DecodeToken(p []byte) ([]byte, error) { | |||
| } | |||
|
|
|||
| func (s *tokenProtectorImpl) createAEAD(nonce []byte) (cipher.AEAD, []byte, error) { | |||
| h := hkdf.New(sha256.New, s.secret, nonce, []byte("quic-go token source")) | |||
| h := hkdf.New(sha256.New, s.key[:], nonce[:], []byte("quic-go token source")) | |||
There was a problem hiding this comment.
NIT: nonce instead of nonce[:]
marten-seemann
commented
Sep 16, 2023
marten-seemann
force-pushed
the
configure-max-token-age
branch
from
6877392
to
a92662e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even more API cleanup. Trying to do all the token-related API changes in one release, to reduce the amount of pain caused for users.
Depends on #4066.