http3: remove RoundTripOpt.CheckSettings #4416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
http3-single-roundtripper-settings
branch
from
448fe69
to
7a71fc4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4416 +/- ##
==========================================
+ Coverage 84.60% 84.68% +0.08%
==========================================
Files 152 152
Lines 14382 14372 -10
==========================================
+ Hits 12167 12170 +3
+ Misses 1710 1699 -11
+ Partials 505 503 -2 ☔ View full report in Codecov by Sentry. |
marten-seemann
force-pushed
the
http3-remove-hijackers
branch
from
12e472d
to
a6bd1d2
Compare
marten-seemann
force-pushed
the
http3-single-roundtripper-settings
branch
from
7a71fc4
to
25307b5
Compare
marten-seemann
force-pushed
the
http3-remove-hijackers
branch
from
a6bd1d2
to
f0a5ff0
Compare
marten-seemann
force-pushed
the
http3-single-roundtripper-settings
branch
from
25307b5
to
8427215
Compare
marten-seemann
force-pushed
the
http3-remove-hijackers
branch
from
f0a5ff0
to
0b8022e
Compare
marten-seemann
force-pushed
the
http3-single-roundtripper-settings
branch
2 times, most recently
from
41456df
to
7021b84
Compare
marten-seemann
force-pushed
the
http3-single-roundtripper-settings
branch
2 times, most recently
from
dd82d91
to
0274a23
Compare
marten-seemann
force-pushed
the
http3-single-roundtripper-settings
branch
from
0274a23
to
fe0509f
Compare
marten-seemann
changed the title
marten-seemann
force-pushed
the
http3-single-roundtripper-settings
branch
from
fe0509f
to
eb22ca7
Compare
marten-seemann
force-pushed
the
http3-single-roundtripper-settings
branch
from
eb22ca7
to
4af97cb
Compare
The settings can be obtained from the SingleDestinationRoundTripper.
marten-seemann
force-pushed
the
http3-single-roundtripper-settings
branch
from
4af97cb
to
a2c01d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4424.Part of #3522.