http3: response body not implemented http3.HTTPStreamer

[phuslu]

Seems that this is broken by #4469

It makes my http3 dialer not working

streamer, ok := resp.Body.(http3.HTTPStreamer)
if !ok {
    return nil, errors.New("proxy: read from " + d.Host + " error: resp body not implemented http3.HTTPStreamer")
}

Any suggestion?

[marten-seemann]

This was called out as a breaking change in the release notes of v0.43. It is now the http.ResponseWriter that implements the interface.

[phuslu]

Thanks. In my understanding the http.ResponseWriter only can be used in server side. (Please correct me if I'm wrong)

How to unwrap the stream in client side (*http.Response), my existing code is here

[marten-seemann]

You'll need to take the path via the SingleDestinationRoundTripper then.

[phuslu]

Last question, shall/do we have a RoundTripOpt to let this underlying stream stay opening?

https://github.com/quic-go/quic-go/blob/v0.44.0/http3/client.go#L299

[phuslu]

Finally I gave up this approach, I turn to another way with more compatibility and but lower performance in phuslu/liner@1054f3b

If the stream unwarp of *http.Response in quic-go/http3 comes back in future, please let me know. thanks again.

[marten-seemann]

Please take a look at the WebTransport dialer: https://github.com/quic-go/webtransport-go/blob/master/client.go

I believe it does exactly what you need.

[phuslu]

Understood, but currently I'd like keep unique/same logic in server side, like https://github.com/phuslu/liner/blob/master/handler_http_forward.go#L278-L298

[marten-seemann]

There’s no change to the server side. This is purely a client side API change.

[phuslu]

thanks for your patience, finally I have a modified webtransport-go dialer of https://github.com/phuslu/liner/blob/master/dialer_http3.go thanks again!