chore: Bump various dependency versions #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docker images to ubuntu:24.04 * ns-3 to 3.4.1 * go to 1.22.3
marten-seemann
approved these changes
May 8, 2024
sim/Dockerfile
Outdated
| ENV GO_VERS 1.21.5 | ||
| RUN wget -O go.tar.gz https://dl.google.com/go/go$GO_VERS.linux-$TARGETARCH.tar.gz | ||
| ENV GO_VERS 1.22.3 | ||
| ADD --checksum=sha256:6c33e52a5b26e7aa021b94475587fce80043a727a54ceb0eee2f9fc160646434 \ |
There was a problem hiding this comment.
I didn't realize Docker allowed verification by SHA256. How cool is that?!
Copy-paste error I assume:
Suggested change
| ADD --checksum=sha256:6c33e52a5b26e7aa021b94475587fce80043a727a54ceb0eee2f9fc160646434 \ | |
| ADD --checksum=sha256: 8920ea521bad8f6b7bc377b4824982e011c19af27df88a815e3586ea895f1b36 \ |
There was a problem hiding this comment.
Oh wait, not a copy-paste error. This is the SHA256 for the arm64, which is why it fails on CI (amd64).
@larseggert How do we fix this?
There was a problem hiding this comment.
Hm. Not sure if there is a way to do this. Do we actually need to install a custom go? 24.04 has go-1.22 via apt.
There was a problem hiding this comment.
They used to have really outdated (multiple years) Go versions. If they have 1.22, we can use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125