Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10$: Improve diagnostics for var\nvar\nvar #233

Closed
strager opened this issue Apr 18, 2021 · 4 comments
Closed

10$: Improve diagnostics for var\nvar\nvar #233

strager opened this issue Apr 18, 2021 · 4 comments
Labels
for hire Get paid for working on this task: https://quick-lint-js.com/hiring.html

Comments

@strager
Copy link
Collaborator

strager commented Apr 18, 2021

quick-lint-js emits confusing diagnostics for the following code:

var
var
var
hello.js:1:1: error: let with no bindings [E024]
hello.js:3:1: error: cannot declare variable named keyword 'var' [E124]

quick-lint-js should report E024 for each line.
@strager strager added the for hire Get paid for working on this task: https://quick-lint-js.com/hiring.html label Apr 18, 2021
@LeeWannacott
Copy link
Contributor

I claim this for-hire task. I expect payment after I complete this task. I will email the quick-lint-js team if I am assigned this task.

@LeeWannacott
Copy link
Contributor

LeeWannacott commented Apr 27, 2021 •
edited

Question 🤔 : Does each line mean?

hello.js:1:1: error: var with no bindings [E024]
hello.js:2:1: error: var with no bindings [E024]
hello.js:3:1: error: var with no bindings [E024]

Or:

hello.js:1:1: error: var with no bindings [E024]
hello.js:3:1: error: var with no bindings [E024]

Note: After the arduous issue of #234 it now outputs error: var, not let.

@strager
Copy link
Collaborator Author

strager commented Apr 27, 2021

Question 🤔 : Does each line mean?

hello.js:1:1: error: var with no bindings [E024]
hello.js:2:1: error: var with no bindings [E024]
hello.js:3:1: error: var with no bindings [E024]

Or:

hello.js:1:1: error: var with no bindings [E024]
hello.js:3:1: error: var with no bindings [E024]

Note: After the arduous issue of #234 it now outputs error: var, not let.

The former: 3 errors, one per var.

@strager strager linked a pull request Apr 29, 2021 that will close this issue
10$: Improve diagnostics for var\nvar\nvar #233 #247
Closed
@strager
Copy link
Collaborator Author

strager commented Jan 31, 2023

I think improving this isn't worth the engineering effort.

@strager strager closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for hire Get paid for working on this task: https://quick-lint-js.com/hiring.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

10$: Improve diagnostics for var\nvar\nvar #233
2 participants
@strager @LeeWannacott