Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consistent indentation formatting #651

Closed
dabrown645 opened this issue Feb 20, 2023 · 2 comments
Closed

feat: consistent indentation formatting #651

dabrown645 opened this issue Feb 20, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dabrown645
Copy link
Contributor

Expected behaviour

I was just working on an enhancement for quickemu and noticed that there is and indentation inconsistancey some use 2 spaces and some 4. Looking the the vim configuration at end of file it specifies 2 spaces for indentation. I also looked at quickget and it has the same kind of inconsistency and the vim configuration specifies 4 spaces.

I am willing to make this change but we need to decide what we want to be consistent on 2 or 4.

Actual behaviour

N/A

Steps to reproduce the behaviour

Outline the step to reproduce the issue you've encountered.

Quickemu output

Run quickemu or quickget and paste the output here.

Linux Distribution & Kernel

Run the following and paste the output.

lsb_release --all
uname -a
@flexiondotorg flexiondotorg added enhancement New feature or request help wanted Extra attention is needed labels Oct 19, 2023
@flexiondotorg
Copy link
Member

4 spaces are typically what is used. I welcome a pull request to clean up the indentation.

@flexiondotorg flexiondotorg changed the title Consistent indentation formating feat: consistent indentation formatting Apr 16, 2024
@flexiondotorg
Copy link
Member

Fixed via #1064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants