Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still necessary? #2

Closed
tehXor opened this issue May 19, 2016 · 4 comments
Closed

Still necessary? #2

tehXor opened this issue May 19, 2016 · 4 comments

Comments

@tehXor
Copy link
Contributor

tehXor commented May 19, 2016

I just installed your module and found out (by accident) that the order of my CSS files was influenced by an "order" attribute just like stated in your readme.md even before your module was activated.
I'm not sure though, because I couldn't find anything related CSS ordering in the official magento documentation and when this happened I already had your module files in my installation. But without running magento setup:upgrade and magento setup:di:compile. I'm still new to Magento 2 so I have no idea if this means your module was totally ineffective at that point or not.

So as you wrote this and have deeper insights, is this module still necessary if we want to change the CSS order by specifying an order attribute in layout files?

@quickshiftin
Copy link
Owner

I'm working on a new installation of Magento 2.1. I'll try to test and see if this is the case and circle back soon.

@xnhinzkyx
Copy link

I think this is not necessary IMO because it still works without using this module but still thanks for this great module. Good job!

@quickshiftin
Copy link
Owner

Hi guys, I finally checked on this with a 2.1 version of Magento and it looks like there still is no built in support for asset ordering. You might want to double-check on your end!

In short, without the module, assets are not ordered, as soon as the module is installed, they are ordered.

I updated the module today, putting it on packagist and cleaning up the installation instructions.

@xnhinzkyx
Copy link

Yeah I tried it the updated version and it works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants