fix the action that handles mailto: URLs
#1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was defined but had no actionSelector.
pjrobertson
added a commit
that referenced
this pull request
Nov 5, 2012
fix the action that handles `mailto:` URLs
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user asked on IRC yesterday why Quicksilver couldn't just use
mailto:for e-mail addresses and let the system take care of the rest.I know all e-mail address objects have
mailto:whatever@whereverassigned as their URL type, so I was going to tell him to use the “Open URL” action, but I found that it wasn't available. Looking into it, I saw that the validation checked formailto:specifically and returned a different action, and that action wasn’t set up correctly.I was going to just remove it and treat
mailto:URL’s like all others, but it occurred to me that using the “Open URL” action on e-mail addresses isn't particularly obvious, and since this other action was 98% defined anyway, I assigned it anactionSelectorinstead (which is all it was missing).