Styles for the release notes #1228
Conversation
Specifically, the same style will be applied to plug-in documentation and release notes.
|
Looks good. I definitely think spicing up the release notes a bit would be good though :) We need to watch out that adding CSS doesn't conflict with what's put on http://qsapp.com/changelog.php |
It doesn't. The plain HTML is written in a separate step. |
|
Here's some tinkering: html {
background-color: rgba(127,75,148,0.2);
}
body {
background: url('../Resources/Quicksilver.icns') no-repeat top right;
background-size: 200px 200px;
background-attachment: fixed;
}Needs a bit of work (we need top make a say 256x256 .png from the .icns and add a bit of padding, maybe transparency) but I think we're there really :) |
I don't like the idea of setting transparency on
Since the release notes open in a browser, we can't refer to any images inside the application. We'd have to alter the release notes to open in our own WebKit view, the way documentation does to use an image. And keep in mind all the documentation uses the same stylesheet. But if we want to separate them, we could always have the script insert |
Doesn't the release notes html file also reside somewhere within the |
Yes, that should work fine. I'm just a moron. :-) I'll change this so it doesn't copy the CSS into the HTML file. |
|
Still, should keep it simple. Don't go to fancy. :-) On Thu, Nov 29, 2012 at 8:04 PM, Rob McBroom notifications@github.com wrote:
|
* reference the CSS instead of including its contents * wrap the release notes in a div (#qsrn) so they can be targeted separately from other documentation
Obviously inspired by TextMate 2's release notes :-)
|
OK, two new commits. Incorporated some of the stuff @pjrobertson suggested. Hopefully not too fancy for @HenningJ. :-) |
|
Yay, my poor CSS attempt worked as expected: it got you fired up about how Henning pointed out the relative paths thing, so cool :) P.S. Webkit defines the canvas as white. Something I figured from playing On 29 November 2012 20:00, Rob McBroom notifications@github.com wrote:
|
|
… meaning you can quite happily use transparency on the html element. But On 29 November 2012 22:00, Patrick Robertson robertson.patrick@gmail.comwrote:
|
|
P.P.S damn your silly typo in the branch name! :P |
Here's my refined take: html {
background-color:#fff;
}
body {
background: url('../Resources/Quicksilver.icns') no-repeat top right;
background-size: 512px 512px;
background-attachment: fixed;
background-color:#fff;
background-color:rgba(128,81,149,0.2);
}
#qsrn ul {
background-color: rgba(242, 237, 245, 0.9);
border-radius: 0.5em;
padding: 1em 1em 1em 2em;
} |
Heh. Never even noticed until now. That should have been a harbinger of all the dumb mistakes I was going to make in this branch. The I'll just put the Doesn't your shell do completion on branch names? :-) |
* body goes edge-to-edge * a new #content div surrounds everything * fixed and enlarged the icon in the release notes
|
More changes:
|
Styles for the release notes
The other day, @HenningJ suggested adding some style to the release notes. Sounds like a good idea, and it's a pretty easy change, so here it is. Nothing too exciting, but's better than before at least.
It's hard to tell exactly what changed in the Xcode project, so I'll explain. (This is under the "Release Notes" build phase of the Preflight target.) I just altered the Python code to read the contents of
QSStyle.cssinto a string, then insert that string into the<head>of the release notes. We can't just link to the file because we don't know where the application will be on disk, so the styles are embedded directly.This is a pull against master, but it's a pretty small if you think the release notes for B71 should look nice. :-)
I'm open to ideas on how to spice it up a little. (Cool background image like the TextMate release notes, anyone?)