Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for UTI file types fixes #1428, #1427 #1430

Merged
merged 2 commits into from
Mar 20, 2013

Conversation

pjrobertson
Copy link
Member

Seems liks QSUTIForExtensionOrType() isn't that reliable for getting the UTI of a file, it was return dyn.agk8u for public.executable files, whereas QSUTIWithLSInfoRec() was doing the right thing, so I switched to that and added a comment

This is against release since this bug pretty much cripples the Terminal Plugin :)

OK seems like GitHub doesn't like chrome. This is against release

@skurfer
Copy link
Member

skurfer commented Mar 19, 2013

Release? It was all done! 💩

😉

@skurfer
Copy link
Member

skurfer commented Mar 19, 2013

This doesn't fix the fact that arguments from the third pane are ignored, but I gather it isn't supposed to.

@pjrobertson
Copy link
Member Author

yeah, that's probably something else. I hadn't looked into it since I don't
have any scripts that take arguments, I guess I could just use something
from /usr/bin though - duh!

Is it too late for release then? If so we'll have to wait for a point
release (We could do a quick one after ß72

On 20 March 2013 01:49, Rob McBroom notifications@github.com wrote:

This doesn't fix the fact that arguments from the third pane are ignored,
but I gather it isn't supposed to.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1430#issuecomment-15135255
.

@skurfer
Copy link
Member

skurfer commented Mar 20, 2013

Not too late, just more work. It'll go in.

@pjrobertson
Copy link
Member Author

k sorry for the extra work :'(

On 20 March 2013 21:36, Rob McBroom notifications@github.com wrote:

Not too late, just more work. It'll go in.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1430#issuecomment-15179165
.

skurfer added a commit that referenced this pull request Mar 20, 2013
Fixes for UTI file types fixes #1428, #1427
@skurfer skurfer merged commit 531c563 into quicksilver:release Mar 20, 2013
skurfer added a commit that referenced this pull request Mar 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants