Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⌃U doesn't clear search string in v1.4.0 #2189

Closed
pjrobertson opened this issue Mar 14, 2016 · 6 comments
Closed

⌃U doesn't clear search string in v1.4.0 #2189

pjrobertson opened this issue Mar 14, 2016 · 6 comments
Labels

Comments

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Mar 14, 2016

I'm assuming some of @skurfer's changes have meant that ⌃U no longer clears the search string. Not sure if it was intentional or not, but it's a change in behaviour... and annoying 😠

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 14, 2016

Surely due to 3785676

But if the object is cleared, what is the search string being applied to? I can’t get anything weird or annoying to happen.

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 14, 2016

Yeah, all delete: does is [self setObjectValue:nil], while clearObjectValue does the exact same thing, plus other stuff specific to the current search object view.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Mar 14, 2016

This is my scenario:

  • type sag and realise it's a typo for safari
  • Press ⌃U to clear the search
  • type safari as I wanted.

But now ⌃U only clears the object and not the search string, so what I end up getting is a search string for sagsafari

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 14, 2016

OK. I can reproduce that if I type fast enough. Are you sure that wasn’t possible in 1.3.x, though? The same code is called.

I don’t see anything in setObjectValue: that would explicitly reset the search, so I guess what you’re seeing makes sense, but again, that’s all it was doing before.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Mar 15, 2016

Just tried 1.3.4 and it works perfectly, so this is a bug here.

Most likely the search timer isn't getting stopped or something. Would there be any disadvantage to changing it back to delete:?

@skurfer
Copy link
Member

@skurfer skurfer commented Mar 15, 2016

Would there be any disadvantage to changing it back to delete:?

Yes. Try changing it back, or just launch 1.3.4, then:

  1. Select a couple of things with ,
  2. Hit ⌃U

Only the main part of the pane is cleared. delete: only seemed to work by voodoo anyway. We should fix it explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants