-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Default action for applications is "Large Text" #2960
Comments
@pjrobertson i wonder if this (and the other issue with shortcuts) could be related to the changes I made to get tests passing, in which I made sure that application paths were also recognized as valid objects for text actions. If so, perhaps default action sorting can use Will need to look into this. On mobile now. |
@corporate-gadfly THANK YOU very much for the screenshots and substantiating that it's not just me. I updated QuickSilver to 2.4.1 on a second Mac and it also repros. @n8henrie I appreciate you looking into this! |
For anyone seeing this, the workaround is to open the Quicksilver settings, go to General -> Actions, search for "large type" and uncheck it. |
The "large type" fix worked for me as well. Sounds like another update is needed. |
This just disables the Unfortunately, I'm unable to reproduce the issue. Can you please try these steps?
|
I can reproduce the problem in the debug build. |
Of course -- the debug build is essentially unchanged from the version used to open the issue. The question is whether the issue persists after quitting QS, deleting Thanks for getting back to me quickly -- can you confirm that you also took the other steps? |
@n8henrie : I hear you. I use I must admit, I'm guilty of not following your debug procedure, but, IMO, all your instructions prove is that this scenario doesn't happen with a clean install of |
I did delete the caches, but I didn't see the bit about hiding the application support folder. Let me try again. |
OK, I don't see the issue when I hide Application Support/Quicksilver. |
So it sounds like the issue possibly has to do with your local configuration or action ranking, possibly something in Can you try restoring your usual app support file but temporarily renaming just that file? (Should probably delete the cache before each trial run regardless). |
Renaming Actions.plist makes the issue go away. Would it help if I uploaded my Actions.plist? |
I can confirm the same. The original file (that I backed up) and the one that automatically got created at next run are radically different. Here's the line count:
|
I'm not sure that uploading your actions plist is necessary, thanks for the offer, I'll let you know if that changes. I think the issue is that applications are now seen as eligible targets for string actions; for example, one can select The issue is that -- for whatever reason -- |
IIRC, for Following that train of thought, is |
"Large type" is rank 24 in the settings. Presumably something is overriding that ranking. |
Oh I just noticed that "open/reveal" is rank 25. I had thought that the rank 1 "run/open" was the open action. If I move that above "large type" it also fixes the issue. |
Naive question. What would I lose by removing the original |
I think you'd lose your history (for example a specific catalog item that you always want to run a specific action for). |
To be fair, I am not seeing this behavior on my pre-existing QS install (updated from 2.4.0 -> 2.4.1 through the in-app updater), nor on a clean install, so I'm trying to figure out how to reproduce the issue. I am concerned that many people are running into it, so I'm trying to sort out what changes are causing this behavior. I've added a few new tests that seem to show the default actions are correct. What I'm speculating may be happening here (and in #2963) is that QS's "smarts" is now detecting that objects like applications can also be interpreted as strings, and is trying to guess the best default action based on a number of inputs, such as:
For example to show the full path to I agree that it doesn't make sense as the default, but the tests above show that it isn't the default -- something about several users' histories is prompting QS to prioritize it. |
Just a wild guess, but this commit removes ".app" from applications. Maybe that affects another test down the road? |
Thanks for the thought! That commit sets the label, which I think was previously empty / unset for applications (and why the test was previously failing). |
@corporate-gadfly -- would you be willing to share your |
oh sorry @n8henrie for the delay. I'm afraid that won't be possible. I deleted the file a couple of weeks ago (sorry about that) and haven't missed it one single bit. |
I believe I'm having the same issue (although Quicksilver keeps trying to "Calculate" apps for me, not "Large Text"). I haven't done any workarounds yet so I'm still experiencing the issue. Here's my Actions.plist file: actions.plist
|
Thanks @aberkvam, I'll take a closer look soon! @corporate-gadfly @torley-gallium Would you please try running the debug version from here and see whether or not the unwanted behavior changes? |
@n8henrie Sorry for the delay, just saw this. I appreciate all your care and investigation. Is there a new debug version to try? 2.4.2 still repros the issue for me (haven't deleted anything else). |
@aberkvam @torley-gallium can you please try this and report back: #2963 (comment) |
@n8henrie Thanks for checking in, so far so good with 2.4.2 . I don't see the enlarged text. |
Before submitting your bug report, please confirm you have completed the following steps
Bug description
QuickSilver 2.4.1 is broken for me on macOS Ventura 13.5.
Every time I try to launch an app, it shows giant text.
Reverted back to 2.4.0, works fine.
Steps to reproduce
Then the directory path of the app appears in a gigantic font, but it doesn't launch.
Expected behavior
It should launch the app and not freeze with giant text.
MacOS Version
macOS 13
Quicksilver Version
2.4.1
Relevant Plugins
No plugins. Just customized some colors but using Bezel.
Crash Logs or Spindump
No response
Screenshots
No response
Additional info
No response
The text was updated successfully, but these errors were encountered: