Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff makes a few changes to expand the ways developers can use tantivy's BM25 scoring:
Bm25Weight
public.Bm25Weight
on aSearcher
. Instead it expects aBm25StatisticsProvider
(which is by default aSearcher
).Bm25StatisticsProvider
when running a query.Some example use cases this unlocks:
Bm25Weight
without the rest of tantivy.Bm25Weight
is also optimized to cache based on fieldnorm which is nice.Bm25StatisticsProvider
should be theSearcher
with adjustments for the data not yet saved to tantivy.Bm25StatisticsProvider
opens the door to storing additional files to correctly track the number of undeleted documents and tokens.My company (Convex) is using (1) and (2) and maybe some day we'll want to do (3) as well.
Let me know if any of this doesn't make sense! Also happy to change the implementation if there is a better way to accomplish these goals.