Better mixed types support in aggs and fix serialization issue #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve support for mixed types in JSON field aggregations (pick the right field, #1913) - Resolve the issue with JSON serialization for numeric keys (fixes #1967) - Add JSON round-trip test for term buckets - Remove `u64_lenient`, as this is a footgun without the type - move aggregation benchmarks
fulmicoton
reviewed
Mar 31, 2023
fulmicoton
reviewed
Mar 31, 2023
fulmicoton
reviewed
Mar 31, 2023
| let (accessor, field_type) = get_ff_reader_and_validate( | ||
| reader, | ||
| field_name, | ||
| Some(get_numeric_or_date_column_types()), |
There was a problem hiding this comment.
does it make sense to allow sum for dates?
(I guess it is does not matter all that much to return a nonsense answer to a nonsense request but...)
There was a problem hiding this comment.
since the baseline with 1970 is arbitrary, no doesn't make sense
fulmicoton
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u64_lenient, as this is a footgun without the type