Change in the query grammar. #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quotation mark can now be used for phrase queries. The delimiter is part of the `UserInputLeaf`. That information is meant to be used in Quickwit to solve #3364. This PR also adds support for quotation marks escaping in phrase queries.
fmassot
reviewed
May 18, 2023
fmassot
reviewed
May 18, 2023
fmassot
approved these changes
May 18, 2023
fulmicoton
commented
May 19, 2023
fulmicoton
commented
May 19, 2023
fulmicoton
commented
May 19, 2023
fulmicoton
commented
May 19, 2023
fulmicoton
force-pushed
the
query-grammar-change
branch
from
8504291
to
d0aa88d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quotation mark can now be used for phrase queries. The delimiter is part of the
UserInputLeaf.That information is meant to be used in Quickwit to solve #3364.
This PR also adds support for quotation marks escaping in phrase queries.