fixes order_by_u64_field and order_by_fast_field should allow sorting in ascending order #1676 #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
reviewed
Jul 4, 2023
| )) | ||
| .unwrap(); | ||
| index_writer | ||
| .add_document(doc!( |
There was a problem hiding this comment.
can you add an empty doc to the test
index_writer.add_document(doc!()).unwrap();There was a problem hiding this comment.
sorry I meant a doc without a value
index_writer.add_document(doc!(title => "empty beer"))There was a problem hiding this comment.
ahh ok. without the size field.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2111 +/- ##
========================================
Coverage 94.39% 94.39%
========================================
Files 321 321
Lines 60650 60797 +147
========================================
+ Hits 57248 57391 +143
- Misses 3402 3406 +4
|
PSeitz
reviewed
Jul 5, 2023
src/collector/top_score_collector.rs
Outdated
| @@ -157,8 +171,13 @@ impl CustomScorer<u64> for ScorerByField { | |||
| sort_column_opt.ok_or_else(|| FastFieldNotAvailableError { | |||
| field_name: self.field.clone(), | |||
| })?; | |||
| let mut value = 0u64; | |||
There was a problem hiding this comment.
Suggested change
| let mut value = 0u64; | |
| let mut default_value = 0u64; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.