RFC: Remove support for Brotli and Snappy compression #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
force-pushed
the
drop-brotli-snappy
branch
from
56e42da
to
864c826
Compare
fulmicoton
approved these changes
Jul 14, 2023
|
@adamreichold can you rebase? |
adamreichold
force-pushed
the
drop-brotli-snappy
branch
from
864c826
to
9390b53
Compare
Done. |
LZ4 provides fast and simple compression whereas Zstd is exceptionally flexible so that the additional support for Brotli and Snappy does not really add any distinct functionality on top of those two algorithms. Removing them reduces our maintenance burden and reduces the number of choices users have to make when setting up their project based on Tantivy.
adamreichold
force-pushed
the
drop-brotli-snappy
branch
from
9390b53
to
0c88c38
Compare
|
Thank you @adamreichold |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2123 +/- ##
=======================================
Coverage 94.37% 94.38%
=======================================
Files 321 319 -2
Lines 60821 60767 -54
=======================================
- Hits 57401 57352 -49
+ Misses 3420 3415 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2121 (comment)
LZ4 provides fast and simple compression whereas Zstd is exceptionally flexible so that the additional support for Brotli and Snappy does not really add any distinct functionality on top of those two algorithms.
Removing them reduces our maintenance burden and reduces the number of choices users have to make when setting up their project based on Tantivy.