Improve aggregation error message #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve aggregation error message by wrapping the deserialization with a custom struct. This deserialization variant is slower, since we need to keep the deserialized data around twice with this approach. For now the valid variants list is manually updated. This could be replaced with a proc macro. closes #2143
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2150 +/- ##
=======================================
Coverage 94.32% 94.33%
=======================================
Files 320 320
Lines 62041 62054 +13
=======================================
+ Hits 58522 58539 +17
+ Misses 3519 3515 -4
|
fulmicoton
reviewed
Aug 21, 2023
src/aggregation/agg_req.rs
Outdated
| /// Aggregation request. | ||
| /// | ||
| /// An aggregation is either a bucket or a metric. | ||
| pub struct AggregationWrapper { |
There was a problem hiding this comment.
why pub and why inline the struct?
fulmicoton
approved these changes
Aug 21, 2023
|
@PSeitz I pushed a commit with a less brittle approach. I leave it to you to modify if necessary and merge. |
Nice, I didn't know about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve aggregation error message by wrapping the deserialization with a
custom struct. This deserialization variant is slower, since we need to
keep the deserialized data around twice with this approach.
For now the valid variants list is manually updated. This could be
replaced with a proc macro.
closes #2143