Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for windows using appveyor. #71

Closed
fulmicoton opened this issue Jan 12, 2017 · 10 comments
Closed

Add CI for windows using appveyor. #71

fulmicoton opened this issue Jan 12, 2017 · 10 comments
Labels

Comments

@fulmicoton
Copy link
Collaborator

Add CI for windows using appveyor.

May want to check out https://github.com/japaric/trust/ to do that in a nicer way

@fulmicoton fulmicoton changed the title AppVeyor Add CI for windows using appveyor. Jan 12, 2017
@KodrAus
Copy link
Contributor

KodrAus commented Feb 18, 2017

I'm looking to get into contributing to tantivy, and wanted to check out trust too so would be happy to pick this one up if you don't have a tight deadline :)

@fulmicoton
Copy link
Collaborator Author

@KodrAus That would be very helpful!

@KodrAus
Copy link
Contributor

KodrAus commented Feb 18, 2017

So I've started taking a look at this and looks like Windows builds fine with GNU and MSVC toolchains so long as we're not trying to build simdcomp, I haven't been able to get that to compile on Windows yet, which isn't a big surprise, it doesn't look like it's really supported. Maybe my mingw-foo is just weak, but it'll be pretty easy to build an AppVeyor build script that excludes it.

I'm still checking out trust, so far it looks like the main benefit is automatic packaging of binary releases for major platforms, which might not be a thing unless you plan to release binaries in the future. It looks like it makes building for non-x86 architectures easier too though, but that also rules out simdcomp.

Have you had any success building tantivy with SIMD for Windows @fulmicoton? I'll go ahead and write an AppVeyor script that excludes SIMD and think more about how it might be supported.

@fulmicoton
Copy link
Collaborator Author

As discussed on gitter, I think it is probably safer to just not support windows.

@KodrAus
Copy link
Contributor

KodrAus commented Feb 19, 2017

We should probably note this in the readme, since it does actually build on Windows. It just kind of doesn't work.

@fulmicoton
Copy link
Collaborator Author

Absolutely. I will do that today... Or if you send me a pull request ill be happy to merge it.

@fulmicoton
Copy link
Collaborator Author

Just added that in README.md

@KodrAus
Copy link
Contributor

KodrAus commented Feb 19, 2017

Cool, so I guess this issue isn't relevant anymore? I opened a specific issue in tantivy-cli for integrating trust there.

@fulmicoton
Copy link
Collaborator Author

We'll eventually want to support windows in a very distant future. In the meanwhile, closing this as won't fix.
@KodrAus thanks for investigating, and creating the other issue.

@fulmicoton
Copy link
Collaborator Author

Was fixed by @KodrAus in #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants