Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in live version -- only display first few packets in sequence view #56

Closed
huitema opened this issue Oct 22, 2021 · 2 comments
Closed

Comments

@huitema
Copy link

huitema commented Oct 22, 2021

Describe the bug
Attached file. There are a couple hundred packets sent each way, but the "sequence" display stops at packet 9.

To Reproduce

  • How did you load the file? From local storage
  • Which visualization had the error? Sequence, server, generated client

Expected behavior
Would liek to see the whole sequence of packets

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
If you are having problems loading a file, please attach it to this issue or email it to us at robin.marx@uhasselt.be

Note that qvis is currently only tested and maintained for the latest stable versions of Google Chrome. -- I was using Firefox.
copied-to-text.txt

@rmarx
Copy link
Member

rmarx commented Oct 25, 2021

Hello @huitema,

I suspect you added recent support for datagram frames and forgot to quote the length field, making it invalid JSON.

Your file has the first unquoted length field at line 170:

[147295, "transport", "packet_received", { "packet_type": "1RTT", "header": { "packet_size": 1440, "packet_number": 9, "dcid": "42ff447d9e71d777" }, "frames": [{ 
    "frame_type": "datagram", length: 1411}]}],

qvis tries to be clever and falls back to a line-by-line parser when it's invalid JSON, but does stop once it encounters a line with an obvious error. As such, you get a nice qlog file of the entries before line 169, and nothing after that.

I replaced all the unquoted lengths with "length" in your example and that seems to load just fine:
quoted-lengths.txt

If this solves your problem, please close this issue.
If not, please let me know!

@huitema
Copy link
Author

huitema commented Oct 25, 2021

Thanks. This is being fixed in picoquic pr #1245

@huitema huitema closed this as completed Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants