Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACKs imply stream state transitions #1667

Closed
MikeBishop opened this issue Aug 15, 2018 · 2 comments
Closed

ACKs imply stream state transitions #1667

MikeBishop opened this issue Aug 15, 2018 · 2 comments
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@MikeBishop
Copy link
Contributor

We have text from a long-ago issue that says:

A packet MUST NOT be acknowledged until packet protection has been successfully removed and all frames contained in the packet have been processed. Any stream state transitions triggered by the frame MUST have occurred.

Since the move to MAX_STREAM_ID and the updated stream state machine, implementations no longer need to track the stream state transitions on the peer, only locally. Do we still need this requirement?
@MikeBishop MikeBishop added design An issue that affects the design of the protocol; resolution requires consensus. -transport labels Aug 15, 2018
@ianswett
Copy link
Contributor

I don't think so?

@martinthomson
Copy link
Member

I don't think that there are any state transitions that would be illegal that would result from this. The "all frames have been processed clause" covers this anyway. Let me double-check the state machines, but I think that this is OK.

@mnot mnot added the has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@martinthomson @mnot @MikeBishop @ianswett