Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should coalescing order be enforced? #1702

Closed
huitema opened this issue Aug 24, 2018 · 1 comment
Closed

Should coalescing order be enforced? #1702

huitema opened this issue Aug 24, 2018 · 1 comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@huitema
Copy link
Contributor

huitema commented Aug 24, 2018

Draft-transport-14 says:

   Senders SHOULD coalesce packets in order of increasing encryption
   levels (Initial, Handshake, 0-RTT, 1-RTT), as this makes it more
   likely the receiver will be able to process all the packets in a
   single pass.  A packet with a short header does not include a length,
   so it will always be the last packet included in a UDP datagram.

The use of normative language here is interesting, and raises a few questions:

  1. The spec says SHOULD. This implicitly means "MAY do something else". What, why, under which circumstances?

  2. Are the peers supposed to enforce that requirement in any way?

In any case, the natural order in which packets are processed is not (Initial, Handshake, 0-RTT, 1-RTT), but rather (Initial, 0-RTT, Handshake, 1-RTT), as in "ACK of Server Hello", "EOED", "Client Finished", "Application data". I suggest rewriting to:

   Coalescing packets in order of increasing encryption
   levels (Initial, 0-RTT, Handshake, 1-RTT) makes it more
   likely the receiver will be able to process all the packets in a
   single pass.  A packet with a short header does not include a length,
   so it will always be the last packet included in a UDP datagram.
@martinthomson
Copy link
Member

This is the result of discussion on #1287, but I like your rewording of this and will commit that change :)

Did I make submitting PRs too difficult?

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

2 participants