Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAX_DATA doesn't comply with MAX_STREAM_DATA #1812

Closed
goelvidhi opened this issue Sep 28, 2018 · 2 comments
Closed

MAX_DATA doesn't comply with MAX_STREAM_DATA #1812

goelvidhi opened this issue Sep 28, 2018 · 2 comments
Labels
-recovery invalid A duplicate, overcome-by-events, ill-formed, or off-topic issue, or a question better asked on-list.

Comments

@goelvidhi
Copy link

Based on the draft, a receiver can compute MAX_DATA as below:

"A receiver might use a sum of bytes consumed on all contributing streams to determine the maximum data limit to be advertised."

But if the receiver misbehaves and advertises MAX_DATA (for example, 2MB) that doesn't comply with MAX_STREAM_DATA (for example, 3MB), does that mean that the sender is blocked if it has already sent up to 2MB?

@marten-seemann
Copy link
Contributor

Yes, that's exactly the point of connection-level flow control.

@MikeBishop
Copy link
Contributor

That's not misbehavior, it's reflecting the fact that stream- and connection-level flow control may have different constraints.

@mnot mnot added -recovery invalid A duplicate, overcome-by-events, ill-formed, or off-topic issue, or a question better asked on-list. labels Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery invalid A duplicate, overcome-by-events, ill-formed, or off-topic issue, or a question better asked on-list.
Projects
None yet
Development

No branches or pull requests

4 participants