Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't resend *all* packets in version negotiation #196

Closed
ekr opened this issue Jan 23, 2017 · 4 comments
Closed

Don't resend *all* packets in version negotiation #196

ekr opened this issue Jan 23, 2017 · 4 comments
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@ekr
Copy link
Collaborator

ekr commented Jan 23, 2017

"
When the client receives a Version Negotiation packet from the
server, it should select an acceptable protocol version. If the
server lists an acceptable version, the client selects that version
and resends all packets using that version. The resent packets MUST
use new packet numbers. These packets MUST continue to have the
VERSION flag set and MUST include the new negotiated protocol
version."

There might be some packets which should not be re-sent if, for instance, they are not relevant for this version of QUIC

@ianswett
Copy link
Contributor

Also, given they have new packet numbers and the framing of a version may change, we should talk about retransmitting frames, not packets in this section.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Jan 24, 2017
@martinthomson
Copy link
Member

I think that this instead needs to say something more generic: start over. Marking this as editorial (let me know if you disagree).

@ianswett
Copy link
Contributor

Agreed, start over is the correct answer.

@martinthomson
Copy link
Member

The new text is better:

If the server lists an acceptable version, the client selects that version and reattempts to create a connection using that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

3 participants