Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DetectLostPackets needs to be per packet number space #2484

Closed
janaiyengar opened this issue Feb 20, 2019 · 1 comment
Closed

DetectLostPackets needs to be per packet number space #2484

janaiyengar opened this issue Feb 20, 2019 · 1 comment
Labels
-recovery design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@janaiyengar
Copy link
Contributor

In particular, largest_acked_packet in DetectLostPackets should be per pn_space.
@janaiyengar janaiyengar added design An issue that affects the design of the protocol; resolution requires consensus. -recovery labels Feb 20, 2019
@marten-seemann marten-seemann mentioned this issue Feb 21, 2019
Merged
@marten-seemann
Copy link
Contributor

marten-seemann commented Feb 21, 2019 •
edited

Since #2417, DetectLostPackets already takes the packet number space. However, the packet number space index for largest_acked_packet is missing there, as well as in OnAckReceived.
For this reason, I don't think this is a design issue, this should be editorial instead.

I created #2485 to fix this.

@mnot mnot added the has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-recovery design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mnot @marten-seemann @janaiyengar