Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-ACK-eliciting packets never need to be ACKed #2931

Closed
dtikhonov opened this issue Jul 26, 2019 · 2 comments
Closed

Non-ACK-eliciting packets never need to be ACKed #2931

dtikhonov opened this issue Jul 26, 2019 · 2 comments

Comments

@dtikhonov
Copy link
Member

By definition, non-ACK-eliciting packets never need to be ACKed. Verbiage introduced in PR #2794 states:

When only non-ACK-eliciting packets need to be acknowledged, ...

I am not sure what the intended meaning was. Perhaps what was meant is "when only non-ACK-eliciting packets have not been acked,..." We could try to find a more graceful way to phrase it.
@mikkelfj
Copy link
Contributor

Non-ack-eliciting packets do need to be ack'ed, they just don't trigger the process.

@dtikhonov
Copy link
Member Author

OK -- closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikkelfj @dtikhonov