Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packets or packet numbers in algorithms/pseudocode #310

Closed
martinthomson opened this issue Feb 15, 2017 · 2 comments
Closed

Use packets or packet numbers in algorithms/pseudocode #310

martinthomson opened this issue Feb 15, 2017 · 2 comments
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@martinthomson
Copy link
Member

The text for DetectLostPackets claims that acked_packet is a packet number, but the code shows it as having a packet_number field, as well as a time_sent field. Maybe a TimeSent() lookup function would work, but at the level that this code operates, I think that it would be better to talk about packets in the abstract. A real implementation might not carry around all the information a packet might accumulate, but that's for real implementations to worry about.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -recovery labels Feb 15, 2017
@martinthomson martinthomson changed the title Packets or packet numbers Use packets or packet numbers in algorithms/pseudocode Feb 15, 2017
@martinthomson
Copy link
Member Author

FWIW, I've fixed this in #304, but only for this specific function. The same problem exists in other functions.

@ianswett
Copy link
Contributor

Fixed by PR #394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

2 participants