Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the definition of things that make messages malformed #3345

Closed
kazuho opened this issue Jan 15, 2020 · 4 comments · Fixed by #3352
Closed

Clarify the definition of things that make messages malformed #3345

kazuho opened this issue Jan 15, 2020 · 4 comments · Fixed by #3352
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@kazuho
Copy link
Member

kazuho commented Jan 15, 2020

Section 4.1.3 of HTTP draft states that a malformed request or response is one that is an otherwise valid sequence of frames but is invalid due to the presence of extraneous frames, prohibited header fields, the absence of mandatory header fields, or the inclusion of uppercase header field names.

Based on the discussion we have been having in #3300, I think we agree that we mean the connection-specific header fields designated in section 8.1.2.2 of RFC 7540.

But in the HTTP/3 draft, I can neither find the corresponding text, or a reference to that part of RFC 7540.

I think we should clarify what the term means.

@MikeBishop MikeBishop added -http editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jan 15, 2020
@MikeBishop
Copy link
Contributor

MikeBishop commented Jan 15, 2020

In Section 4.1.1:

The restrictions on the use of pseudo-header fields in Section 8.1.2 of [HTTP2] also apply to HTTP/3.

This also feeds into #3264, which suggests those prohibitions should be local to the document.

@kazuho
Copy link
Member Author

kazuho commented Jan 15, 2020

connection-specific header fields (e.g., transfer-encoding) are not pseudo-header fields.

@MikeBishop MikeBishop changed the title Clarify what "prohibited header fields" are Clarify the definition of things that make messages malformed Jan 15, 2020
@MikeBishop
Copy link
Contributor

Fair enough. I think I'd like to generalize this issue:

Let's make "malformed" more precise, and that should resolve most of our differences on #3300.

@mnot mnot added this to Editorial Issues in Late Stage Processing Jan 15, 2020
@MikeBishop MikeBishop removed the editorial An issue that does not affect the design of the protocol; does not require consensus. label Jan 16, 2020
@MikeBishop
Copy link
Contributor

@mnot, @larseggert, @LPardue: The fix to this will not be editorial, because it mandates certain things which were stream errors now become connection errors.

@mnot mnot moved this from Editorial Issues to Triage in Late Stage Processing Jan 17, 2020
@mnot mnot added the design An issue that affects the design of the protocol; resolution requires consensus. label Jan 17, 2020
@mnot mnot moved this from Triage to Design Issues in Late Stage Processing Jan 17, 2020
@MikeBishop MikeBishop added the proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. label Jan 21, 2020
@project-bot project-bot bot moved this from Design Issues to Consensus Emerging in Late Stage Processing Jan 21, 2020
@mnot mnot removed the proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. label Jan 24, 2020
@mnot mnot moved this from Consensus Emerging to Consensus Call issued in Late Stage Processing Jan 24, 2020
@mnot mnot added the has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. label Feb 5, 2020
@project-bot project-bot bot moved this from Consensus Call issued to Consensus Declared in Late Stage Processing Feb 5, 2020
Late Stage Processing automation moved this from Consensus Declared to Text Incorporated Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
Late Stage Processing
  
Issue Handled
Development

Successfully merging a pull request may close this issue.

3 participants