Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error code for increasing stream_id in GOAWAY frames #3616

Closed
ddragana opened this issue Apr 30, 2020 · 3 comments
Closed

Error code for increasing stream_id in GOAWAY frames #3616

ddragana opened this issue Apr 30, 2020 · 3 comments

Comments

@ddragana
Copy link
Contributor

The spec defines this as MUST NOT:

An endpoint MAY send multiple GOAWAY frames indicating different identifiers, but MUST NOT increase the identifier value they send, since clients might already have retried unprocessed requests on another connection.

we should define an error code for this?
I do not see that it is define, maybe I missed it somewhere.

@martinthomson
Copy link
Member

We can define our own internal error code for this and report that as a generic error.

@larseggert larseggert added this to Triage in Late Stage Processing via automation Apr 30, 2020
@ddragana
Copy link
Contributor Author

We can define our own internal error code for this and report that as a generic error.

I am fine with that. Adding a description to the "Reason Phrase" in CONNECTION_CLOSE frame is enough.

@LPardue
Copy link
Member

LPardue commented May 1, 2020

Seems like you have a solution that does not require any spec changes so I'm closing this. Reopen the ticket if my assessment is wrong.

@LPardue LPardue closed this as completed May 1, 2020
Late Stage Processing automation moved this from Triage to Issue Handled May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Late Stage Processing
  
Issue Handled
Development

No branches or pull requests

4 participants