Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamps in acknowledgment of PING? #388

Closed
martinthomson opened this issue Mar 12, 2017 · 3 comments
Closed

Timestamps in acknowledgment of PING? #388

martinthomson opened this issue Mar 12, 2017 · 3 comments
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@martinthomson
Copy link
Member

Should we encourage implementations to include a timestamp for the specific packet that contains a PING when acknowledging it?
@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -transport labels Mar 12, 2017
@ianswett
Copy link
Contributor

PING frames are retransmittable, so the current text in 8.2 indicates one SHOULD include a timestamp. This seems reasonable. Is there a reason to do something else?

@martinthomson
Copy link
Member Author

The text says: " A receiver SHOULD send a timestamp exactly once for each retransmittable packet recevied." Which doesn't really directly identify PING. (Also, typo, and packets arent' retransmittable.)

@ianswett
Copy link
Contributor

Yes, it should be "for each received packet containing retransmittable frames."

It doesn't directly address PING, but a PING is retransmittable, so I don't think it needs to.

@ianswett ianswett mentioned this issue Mar 13, 2017
Merged
@mnot mnot added the has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. label Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martinthomson @mnot @ianswett