Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_ack_delay in recovery pseudocode #3920

Closed
kazu-yamamoto opened this issue Jul 17, 2020 · 0 comments · Fixed by #3938
Closed

max_ack_delay in recovery pseudocode #3920

kazu-yamamoto opened this issue Jul 17, 2020 · 0 comments · Fixed by #3938
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing

Comments

@kazu-yamamoto
Copy link
Contributor

The spec says that 0 should be used for max_ack_delay in Initial and Handshake. In pseudo code, max_ack_delay is used at three places.

In InPersistentCongestion, non-zero value of max_ack_delay is used for Initial and Handshake, which should be fixed. Other two places looks good.
@larseggert larseggert added this to Triage in Late Stage Processing via automation Jul 17, 2020
@janaiyengar janaiyengar added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Jul 18, 2020
@project-bot project-bot bot moved this from Triage to Editorial Issues in Late Stage Processing Jul 18, 2020
@kazu-yamamoto kazu-yamamoto mentioned this issue Jul 22, 2020
Merged
Late Stage Processing automation moved this from Editorial Issues to Issue Handled Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing max_ack_delay kazu-yamamoto/base-drafts
3 participants
@kazu-yamamoto @LPardue @janaiyengar