Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain format more #4292

Closed
larseggert opened this issue Oct 28, 2020 · 7 comments
Closed

Explain format more #4292

larseggert opened this issue Oct 28, 2020 · 7 comments
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus. ietf-lc An issue that was raised during IETF Last Call.

Comments

@larseggert
Copy link
Member

The layout of a Version Negotiation packet is:

Version Negotiation Packet {
Header Form (1) = 1,
Unused (7),
Version (32) = 0,
Destination Connection ID Length (8),
Destination Connection ID (0..2040),
Source Connection ID Length (8),
Source Connection ID (0..2040),
Supported Version (32) ...,
}

             Figure 14: Version Negotiation Packet

The value in the Unused field is selected randomly by the server.

When I first met this text the following questions arose.
What does the (7) in unused mean?
What length is Destination/Source Connection ID/What does (0..2040) mean?
Now I have figured this out, but I really worry about how difficult this is
for the new/casual reader of the text.

@larseggert larseggert added -transport ietf-lc An issue that was raised during IETF Last Call. labels Oct 28, 2020
@larseggert larseggert added this to the transport-genart milestone Oct 28, 2020
@larseggert larseggert added this to Triage in Late Stage Processing via automation Oct 28, 2020
@MikeBishop
Copy link
Contributor

The notation is described in Section 1.3, before it is ever used in the document. It seems excessive to refer back to the diagram conventions from every diagram. I'm not sure what would make this clearer for a reader who doesn't read the introduction.

@janaiyengar
Copy link
Contributor

This might be difficult for a casual reader of the text, but I would argue that we shouldn't optimize for them. As Mike notes, there are a large number of diagrams, and the notations section exists precisely to capture common notation that is used throughout the document.

@StewartBryant
Copy link

I think perhaps a small tutorial section somewhere, either in the beginning or forward referenced to an appendix would help.

Remember other target audiences are people who are used to conventional definitions of transport protocols some of whom need to operate the network and some of whom only need to know enough to design adjacent layers (for example the routing engineers).

@MikeBishop
Copy link
Contributor

Can you suggest what you'd expect to see in such a tutorial beyond what exists in Section 1.3?

@martinthomson martinthomson added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Nov 5, 2020
@project-bot project-bot bot moved this from Triage to Editorial Issues in Late Stage Processing Nov 5, 2020
@janaiyengar
Copy link
Contributor

What @MikeBishop asks.

@StewartBryant : Other target audiences still ought to be careful readers of the document. I hope that those who operate the network don't do it with a casual reading of protocol documents.

@janaiyengar
Copy link
Contributor

I'm marking this as proposal-ready. We can switch it back if we decide to do something here.

@janaiyengar janaiyengar added the proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. label Nov 7, 2020
@project-bot project-bot bot moved this from Editorial Issues to Consensus Emerging in Late Stage Processing Nov 7, 2020
@LPardue
Copy link
Member

LPardue commented Dec 8, 2020

The proposed resolution was to close to with action, which was signalled to the appropriate review channel.

Hearing no pushback, I'm closing this.

@LPardue LPardue closed this as completed Dec 8, 2020
Late Stage Processing automation moved this from Consensus Emerging to Issue Handled Dec 8, 2020
@LPardue LPardue removed the proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus. ietf-lc An issue that was raised during IETF Last Call.
Projects
Late Stage Processing
  
Issue Handled
Development

No branches or pull requests

6 participants