Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion pseudo code would be helpful #4300

Closed
larseggert opened this issue Oct 28, 2020 · 2 comments · Fixed by #4316
Closed

Conversion pseudo code would be helpful #4300

larseggert opened this issue Oct 28, 2020 · 2 comments · Fixed by #4316
Labels
-transport ietf-lc An issue that was raised during IETF Last Call.

Comments

@larseggert
Copy link
Member

             Table 4: Summary of Integer Encodings

For example, the eight byte sequence c2 19 7c 5e ff 14 e8 8c (in
hexadecimal) decodes to the decimal value 151288809941952652; the
four byte sequence 9d 7f 3e 7d decodes to 494878333; the two byte
sequence 7b bd decodes to 15293; and the single byte 25 decodes to 37
(as does the two byte sequence 40 25).

The
Some hex & decimal indication would help.
A picture is worth a thousand words and save the reader drawing this out
themselves to understand it and getting confused. The conversion pseudo
code would be helpful, possibly in an appendix.

@larseggert larseggert added -transport ietf-lc An issue that was raised during IETF Last Call. labels Oct 28, 2020
@larseggert larseggert added this to the transport-genart milestone Oct 28, 2020
@larseggert larseggert added this to Triage in Late Stage Processing via automation Oct 28, 2020
@martinthomson
Copy link
Member

I don't think that any change is needed here. It says "in hexadecimal" and "decimal value" right there.

@MikeBishop
Copy link
Contributor

We could put comma separators in the decimal values (i.e. 494878333 => 494,878,333) so they're more readily parsed as decimals rather than digit sequences. And an appendix with a varint decoder might not be the worst idea.

Late Stage Processing automation moved this from Triage to Issue Handled Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport ietf-lc An issue that was raised during IETF Last Call.
Projects
Late Stage Processing
  
Issue Handled
Development

Successfully merging a pull request may close this issue.

3 participants