Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ben Kaduk's Recovery Comment 2 #4709

Closed
LPardue opened this issue Jan 8, 2021 · 4 comments
Closed

Ben Kaduk's Recovery Comment 2 #4709

LPardue opened this issue Jan 8, 2021 · 4 comments
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus. iesg An issue raised during IESG review.
Milestone

Comments

@LPardue
Copy link
Member

LPardue commented Jan 8, 2021

@kaduk said:

Section 5.3

After the handshake is confirmed, any acknowledgement delays reported
by the peer that are greater than the peer's max_ack_delay are
attributed to unintentional but potentially repeating delays, such as
scheduler latency at the peer or loss of previous acknowledgements.

I don't think I understand how loss of previous acknowledgements could
induce a peer to delay sending an ack longer than its max_ack_delay
after an ack-eliciting packet.

@LPardue LPardue added -recovery iesg An issue raised during IESG review. labels Jan 8, 2021
@LPardue LPardue added this to the recovery-iesg milestone Jan 8, 2021
@larseggert larseggert added this to Triage in Late Stage Processing via automation Jan 11, 2021
@janaiyengar
Copy link
Contributor

ack_delay in an ACK frame is recorded as the time since the largest_acknowledged packet was received. If the largest_acknowledged does not change as subsequent ACK frames are sent by the receiver, ack_delay only increases in subsequent ACK frames. Now, if there's no acknowledgement loss, the receiver of acknowledgements would read the first ack_delay in the first such ACK frame. If there is loss however, the receiver of acknowledgements would read only subsequent ACK frames, which might have ack_delay that is larger than max_ack_delay.

Does that help?

I propose closing with no action.

@larseggert larseggert added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Jan 12, 2021
@project-bot project-bot bot moved this from Triage to Editorial Issues in Late Stage Processing Jan 12, 2021
@larseggert
Copy link
Member

@kaduk does this explanation and proposed resolution work for you?

@kaduk
Copy link
Contributor

kaduk commented Jan 13, 2021

That helps, yes, and thank you. I think I was confused about which direction of ACKs were getting lost.
"loss of previous acknowledgments of the same packet" or "loss of previous attempts to acknowledge the packet in question" would have averted my confusion, though I concede that neither flows terribly well.

@larseggert
Copy link
Member

OK, closing with no action as agreed.

Late Stage Processing automation moved this from Editorial Issues to Issue Handled Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus. iesg An issue raised during IESG review.
Projects
Late Stage Processing
  
Issue Handled
Development

No branches or pull requests

4 participants