Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use positive phrasing instead of double negative #477

Closed
sebdeckers opened this issue Apr 27, 2017 · 2 comments
Closed

Use positive phrasing instead of double negative #477

sebdeckers opened this issue Apr 27, 2017 · 2 comments
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.

Comments

@sebdeckers
Copy link
Contributor

The setting SETTINGS_DISABLE_PUSH is set to false by default. This double negation seems needlessly confusing. ("Setting the push setting to true turns off push?")

Suggestion: Renaming it to SETTINGS_ENABLE_PUSH and default to true. This is easier to understand and matches the parameter defined by HTTP/2.

@MikeBishop
Copy link
Contributor

The problem is that we've defined Boolean settings in general to be false if not sent, true if sent. So to have it be "enable push," it either needs to default off or we need to change the polarity of all Boolean settings. I don't think changing the polarity of settings is an acceptable option since HTTP allows definition of arbitrary settings by extensions, all of which would need to be off by default unless a client supports the extension.

I'm fine switching it back to ENABLE_PUSH and requiring that an extra few bytes be spent if you want things pushed to you, though. Any objections?

@martinthomson
Copy link
Member

Given that this is the client, which is expected to add padding in the relevant packet, the extra bytes won't be increasing the size of anything.

@martinthomson martinthomson added the design An issue that affects the design of the protocol; resolution requires consensus. label Apr 28, 2017
@mnot mnot added this to Odd Jobs in HTTP Apr 28, 2017
@mnot mnot removed this from Odd Jobs in HTTP Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Development

No branches or pull requests

3 participants