Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type octet language and public reset value #527

Closed
mcmanus opened this issue May 16, 2017 · 3 comments
Closed

type octet language and public reset value #527

mcmanus opened this issue May 16, 2017 · 3 comments
Assignees
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@mcmanus
Copy link
Contributor

mcmanus commented May 16, 2017

transport commonly refers to a type octet when referring to long header packet types.. (e.g. 0x88) but the type field is defined as 7 bits and the long header packet type table lists values without the high bit (e.g. 0x08). I think we're better off without the type octet concept.

Also, public reset is defined in the table as having value 9, but in 5.6 as having a type octet of 0x88 which is already used by keyphase 1 protected packets. I think 9/0x89 is the intention. I would open a separate issue, but the merge conflict is inevitable :)

@janaiyengar
Copy link
Contributor

"type field", then?
or we can go with "type septet" :-)

@janaiyengar
Copy link
Contributor

I think this change sounds reasonable.

@janaiyengar janaiyengar self-assigned this May 16, 2017
@janaiyengar janaiyengar added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels May 16, 2017
@janaiyengar janaiyengar assigned mcmanus and unassigned janaiyengar May 16, 2017
@janaiyengar
Copy link
Contributor

Addressed in #528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

2 participants