-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packet number text limitation on 32 bits of packet number #566
Comments
I was about to fill the same issue this afternoon (and then got distracted). We could remove the number completely or say that the internal packet number size must be at least 64 bits |
I think that we separately agreed to remove the 48 from the ACK frame. |
-04 still allows 48 bits in the ACK frame? |
Only because we didn't get around to making those changes. We agreed to move fast on -04 and we didn't have a PR for removing 48. |
this is a dup of #507 so closing. |
I didn't realize we were cutting 04 today, but PR #629 has now fixed the 48 bit issue. |
5.8 introduces the fact that only the least significant bits of a packet number are transmitted and it goes on to say at most 32.
But acks can use 48.
I suggest fixing by just leaving out the number.
The text was updated successfully, but these errors were encountered: