Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packet number text limitation on 32 bits of packet number #566

Closed
mcmanus opened this issue Jun 1, 2017 · 7 comments
Closed

packet number text limitation on 32 bits of packet number #566

mcmanus opened this issue Jun 1, 2017 · 7 comments
Labels
invalid A duplicate, overcome-by-events, ill-formed, or off-topic issue, or a question better asked on-list.

Comments

@mcmanus
Copy link
Contributor

mcmanus commented Jun 1, 2017

5.8 introduces the fact that only the least significant bits of a packet number are transmitted and it goes on to say at most 32.

But acks can use 48.

I suggest fixing by just leaving out the number.

@mirjak
Copy link
Contributor

mirjak commented Jun 1, 2017

I was about to fill the same issue this afternoon (and then got distracted). We could remove the number completely or say that the internal packet number size must be at least 64 bits

@martinthomson
Copy link
Member

I think that we separately agreed to remove the 48 from the ACK frame.

@larseggert
Copy link
Member

Yes, see #507 (and #508)

@larseggert
Copy link
Member

-04 still allows 48 bits in the ACK frame?

@martinthomson
Copy link
Member

Only because we didn't get around to making those changes. We agreed to move fast on -04 and we didn't have a PR for removing 48.

@janaiyengar
Copy link
Contributor

this is a dup of #507 so closing.

@ianswett
Copy link
Contributor

I didn't realize we were cutting 04 today, but PR #629 has now fixed the 48 bit issue.

@mnot mnot added the duplicate label Sep 25, 2017
@mnot mnot added the invalid A duplicate, overcome-by-events, ill-formed, or off-topic issue, or a question better asked on-list. label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid A duplicate, overcome-by-events, ill-formed, or off-topic issue, or a question better asked on-list.
Projects
None yet
Development

No branches or pull requests

7 participants