Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetransmitAllHandshakePackets() and SetLossDetectionAlarm() #625

Closed
larseggert opened this issue Jun 12, 2017 · 1 comment
Closed

RetransmitAllHandshakePackets() and SetLossDetectionAlarm() #625

larseggert opened this issue Jun 12, 2017 · 1 comment
Assignees
@janaiyengar @ianswett
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@larseggert
Copy link
Member

RetransmitAllHandshakePackets() is not further defined in the loss-recovery ID. But it is implied that when executing this, one would also execute OnPacketSent(), which produces the effect hat SetLossDetectionAlarm() is called twice for the same transmission event. That is clearly not intended.
@larseggert larseggert added -recovery editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jun 12, 2017
@larseggert
Copy link
Member Author

So RetransmitAllHandshakePackets() is still not defined in -10.

I am not sure if the issue around SetLossDetectionAlarm() being called twice from the pseudo code codepath is still an issue.

@ianswett ianswett mentioned this issue Mar 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janaiyengar janaiyengar

@ianswett ianswett

Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@larseggert @janaiyengar @ianswett