Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some error codes #670

Closed
martinthomson opened this issue Jun 27, 2017 · 1 comment
Closed

Add some error codes #670

martinthomson opened this issue Jun 27, 2017 · 1 comment
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@martinthomson
Copy link
Member

In #467, we removed a bunch of error codes. This tracks whether we want to restore any of those.

The following might be invalid: HANDSHAKE_TIMEOUT, NETWORK_IDLE_TIMEOUT, PUBLIC_RESET_RECEIVED, TOO_MANY_RTOS.

The following probably depend on a resolution to #608: UNENCRYPTED_STREAM_DATA, INVALID_VERSION_NEGOTIATION_PACKET, ADDRESS_VALIDATION_FAILURE

A code for closing the crypto stream (or critical streams, if we ever have that concept) might depend on #485.

For PAYLOAD_MISSING we already have generic codes that could be used, we might also not bother to decrypt a packet that is only long enough to hold the authentication tag and so the error might never be detected.

When adding these back, we should describe the conditions under which they are generated.

@martinthomson martinthomson added -transport design An issue that affects the design of the protocol; resolution requires consensus. labels Jun 27, 2017
@mnot mnot added this to Closing, Shutdown, Reset in QUIC Sep 5, 2017
@ianswett
Copy link
Contributor

Will re-add connection close errors as necessary in the text.

@mnot mnot removed this from Connection End in QUIC Mar 15, 2018
@mnot mnot added the has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Development

No branches or pull requests

3 participants