New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't retransmit old MAX_STREAM_DATA #806
Comments
Agreed, this is silly. |
This is silly. We could say something along the lines of "the newest MAX_STREAM_DATA and MAX_DATA MUST be retransmitted until acked; all other previous flow control advertisements SHOULD NOT be retransmitted." |
Or as I have said on numerous occasions, we should rewrite this section so that it concentrates on the retransmission of the information contained in frames rather than the frames themselves. We have the same problem with all frame types that are used to carry data that needs to be reliably delivered to the other side, why not fix it systematically rather than piecemeal. The text above shows that we've done that for STREAM and ACK. The only frame that doesn't carry information that needs to be reliably delivered is PADDING. |
Agreed, misuse of the word retransmit is a widespread issue. On the positive side, it should be an uncontroversial editorial fix. |
I think as a short-term fix we should do what Jana suggests. Minq presently does that. And the spec is so wrong now we should fix that ASAP As a long-term fix, I think what we want is actually that when you discover it is time to retransmit MAX_STREAM_DATA (e.g., timer expired, you discover the data was lost) you send the then-current flow control window. That seems like it will be more accurate. |
The current text says that one ought to retransmit MAX_STREAM_DATA:
But this is silly. Say I transmitted MAX_STREAM_DATA=100, MAX_STREAM_DATA=200, MAX_STREAM_DATA=300 and then none of them were acknowledged. Why am I retransmitting frames which must be ignored.
The text was updated successfully, but these errors were encountered: