Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nits for manageability #381

Closed
larseggert opened this issue May 26, 2021 · 1 comment · Fixed by #374
Closed

Nits for manageability #381

larseggert opened this issue May 26, 2021 · 1 comment · Fixed by #374

Comments

@larseggert
Copy link
Member

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

"Table of Contents", paragraph 2, nit:
> sion 1 was designed primarily as a transport for HTTP, with the resulting pro
>                                  ^^^^^^^^^^^
Uncountable nouns are usually not used with an indefinite article. Use simply
"transport".

Section 2.4, paragraph 8, nit:
> sed. The content of Initial packets are encrypted using Initial Secrets, whi
>                                     ^^^
Possible agreement error.

Section 2.4, paragraph 17, nit:
> IC ACK frame (acknowledging Server Initial Initial) | | +--------------------
>                                    ^^^^^^^^^^^^^^^
Possible typo: you repeated a word

Section 2.5, paragraph 1, nit:
> ving a new connection ID does not necessary indicate a new connection. [QUIC
>                                   ^^^^^^^^^
The word "necessary" is an adjective and doesn't fit in this context. Did you
mean the adverb "necessarily"?

Section 2.6, paragraph 3, nit:
> verify that they were authentic. Therefore any modification of this list wil
>                                  ^^^^^^^^^
Did you forget a comma after a conjunctive/linking adverb?

Section 2.6, paragraph 4, nit:
> ard versions, will be deployed in the Internet more often than with tradition
>                                ^^^^^^^^^^^^^^^
The usual collocation for technology is "on", not "in".

Section 2.8, paragraph 3, nit:
> lid. HTTP/3 uses UDP port 443 by convention but various methods can be used t
>                                  ^^^^^^^^^^
Use a comma before 'but' if it connects two independent clauses (unless they
are closely connected and short).

Section 3.2, paragraph 1, nit:
>  likely to fail, and are not recommended to use as a way to construe interna
>                              ^^^^^^^^^^^^^^^^^^
The verb 'recommended' is used with the gerund form: "recommended using".

Section 3.8.1, paragraph 2, nit:
> lay (e.g., delayed sending of acknowledgements) and/or application layer del
>                               ^^^^^^^^^^^^^^^^
Do not mix variants of the same word ('acknowledgement' and 'acknowledgment')
within a single text.

Section 4.2, paragraph 2, nit:
> tion is not visible to the path. Therefore using the connection ID as a flow
>                                  ^^^^^^^^^
Did you forget a comma after a conjunctive/linking adverb?

Section 4.2, paragraph 10, nit:
> ets and then make a decision as to whether or not to filter it. QUIC applicat
>                              ^^^^^^^^^^^^^^^^^^^^
Wordiness: Consider shortening this phrase.

Section 4.3, paragraph 4, nit:
> ket loss (see also Section 4.5). Therefore UDP throttling should be realized
>                                  ^^^^^^^^^
Did you forget a comma after a conjunctive/linking adverb?

Section 4.10, paragraph 3, nit:
> se Version Negotiation packets are require to define a mechanism that is robu
>                                    ^^^^^^^
Consider using either the past participle "required" or the present participle
"requiring" here.

Section 4.10, paragraph 3, nit:
> ainst version downgrade attacks. Therefore a network node should not attempt
>                                  ^^^^^^^^^
Did you forget a comma after a conjunctive/linking adverb?

Document references draft-ietf-dots-architecture, but that has been published
as RFC8811.
@mirjak
Copy link
Contributor

mirjak commented May 26, 2021

thanks! added to #374

@mirjak mirjak linked a pull request May 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants